Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM]Revert "Cabinet Refactor" to see if defibs get fixed #3470

Closed
wants to merge 1 commit into from

Conversation

rye-rice
Copy link
Member

@rye-rice rye-rice commented Oct 2, 2024

Ditto

If it does it will be kept on TM
Reverts #3378

@keywordlabeler keywordlabeler bot added the Do Not Merge You probably made someone angry, or you're stopping people from getting angry. label Oct 2, 2024
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Code change Watch something violently break. labels Oct 2, 2024
@Erikafox
Copy link
Contributor

Erikafox commented Oct 2, 2024

yeah it's probably the checking for trait_wielded instead of the var or whatever in the defibs

@github-actions github-actions bot requested a review from FalloutFalcon October 2, 2024 22:11
@rye-rice
Copy link
Member Author

rye-rice commented Oct 2, 2024

cwan ywou fwix iwt erwika qwq

@Erikafox
Copy link
Contributor

Erikafox commented Oct 2, 2024

im gaming right now otherwise i would. i need to get my weekly autistic girlthing rep in.

@Erikafox
Copy link
Contributor

Erikafox commented Oct 2, 2024

if you want to fix it search for TRAIT_WIELDED in defib.dm

@FalloutFalcon
Copy link
Member

yeah it's probably the checking for trait_wielded instead of the var or whatever in the defibs

its the opposite.
its checking for the wielded var but you removed the thing that updates it
you just need to refactor the stuff to use the trait

@Erikafox
Copy link
Contributor

Erikafox commented Oct 2, 2024

MANY such cases of a problem just because of me being stupid

@rye-rice rye-rice closed this Oct 3, 2024
@FalloutFalcon FalloutFalcon deleted the revert-3378-wacky_cabinets branch October 6, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Do Not Merge You probably made someone angry, or you're stopping people from getting angry. Map Change Tile placing is hard. Thank you for your service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants